Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

modify spack develop #888

Merged
merged 10 commits into from
Mar 18, 2025
Merged

modify spack develop #888

merged 10 commits into from
Mar 18, 2025

Conversation

atteggiani
Copy link
Contributor

@atteggiani atteggiani commented Mar 5, 2025 •
edited
Loading

Fixes #873

Overview of the modifications

  • Changed --fresh to --reuse-deps
  • Restructured spack develop instructions to be more informative and add mentions to package specifier syntax and required spack.yaml fixes
  • Other minor additions

@atteggiani atteggiani self-assigned this Mar 5, 2025
@atteggiani atteggiani requested a review from a team March 5, 2025 00:55
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 5, 2025 •
edited
Loading

PR preview
🛬 Preview link removed because the pull request was closed.

@atteggiani atteggiani requested review from harshula and heidinett and removed request for a team March 5, 2025 00:55
@atteggiani atteggiani changed the title davide/modify spack develop modify spack develop Mar 5, 2025
@harshula
Copy link
Contributor

harshula commented Mar 5, 2025

Hi @atteggiani , The consensus was to tell the user to try --reuse-deps first, and if it fails, then use --fresh.

@atteggiani
Copy link
Contributor Author

Hi @atteggiani , The consensus was to tell the user to try --reuse-deps first, and if it fails, then use --fresh.

Added in dbc818d8c98a520eb120a3f083c6cad7d859aa63

@atteggiani atteggiani mentioned this pull request Mar 5, 2025
Open
@atteggiani
Copy link
Contributor Author

Card for the "create a prerelease" page added in 1aa99cccf9f64caf64f4f3ea9d81c7a16ef79820

@atteggiani atteggiani requested a review from harshula March 13, 2025 23:01
@atteggiani atteggiani requested a review from harshula March 17, 2025 05:41
harshula
harshula requested changes Mar 17, 2025
View reviewed changes
Copy link
Contributor

@harshula harshula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Small typo needs to be fixed.

@atteggiani atteggiani requested a review from harshula March 17, 2025 23:05
@atteggiani atteggiani merged commit dc5d797 into development Mar 18, 2025
11 of 12 checks passed
@atteggiani atteggiani deleted the davide/modify_spack_develop branch March 18, 2025 02:58
@atteggiani
Copy link
Contributor Author

Thank you @harshula and @chrisb13.
Merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisb13 chrisb13 chrisb13 left review comments

@harshula harshula harshula approved these changes

@heidinett heidinett Awaiting requested review from heidinett

Assignees

@atteggiani atteggiani

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"Modify an ACCESS model's source code" doc needs an additional step in the spack develop instructions
3 participants
@atteggiani @harshula @chrisb13