Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interim model-db Update: Only Ingest Gadi Metadata #214

Merged
merged 3 commits into from
Jan 23, 2025

Conversation

CodeGat
Copy link
Member

@CodeGat CodeGat commented Jan 22, 2025

Closes #212

Background

Currently, the model-db section of the multi-target workflow doesn't work, because we renamed a bunch of the metadata/outputs to have target-specific filenames (e.g Gadi.spack.lock, deploy-outputs.Gadi).

In this PR, we are restoring the original functionality in which the model-db is updated with Gadi-specific information, until we have an updated provenance database, which will come about through ACCESS-NRI/tracking-services#23.

In this PR:

  • generate-build-metadata.bash: Reference explicit Gadi.* files
  • tests/scripts/generate-build-metadata: Updated test data inputs/outputs
  • cd.yml: Use Gadi-specific outputs/metadata for build-db upload

Testing

Tested using the updated tests/scripts/generate-build-metadata tests.

@CodeGat CodeGat added type:enhancement Improvements to existing features priority:medium version:MINOR Doesn't require update to Model Deployment Repositories labels Jan 22, 2025
@CodeGat CodeGat self-assigned this Jan 22, 2025
@CodeGat CodeGat marked this pull request as ready for review January 22, 2025 04:25
@CodeGat CodeGat force-pushed the 212-interim-model-db-fix branch from 2f76d7f to a0f0bbe Compare January 23, 2025 03:50
Copy link
Contributor

@jo-basevi jo-basevi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@CodeGat CodeGat merged commit 8292e25 into dev-121-multi-target-workflows Jan 23, 2025
2 checks passed
@CodeGat CodeGat deleted the 212-interim-model-db-fix branch January 23, 2025 04:38
@CodeGat CodeGat mentioned this pull request Jan 23, 2025
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority:medium type:enhancement Improvements to existing features version:MINOR Doesn't require update to Model Deployment Repositories
Projects
Status: Done ✅
Development

Successfully merging this pull request may close these issues.

2 participants