Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update remote temp spack manifest name to prevent ambiguity #253

Merged
merged 1 commit into from
Mar 18, 2025

Conversation

CodeGat
Copy link
Member

@CodeGat CodeGat commented Mar 18, 2025

See ACCESS-NRI/ACCESS-OM3#64, specifically ACCESS-NRI/ACCESS-OM3#64 (comment)

Background

When a large amount of prereleases from the same repository are created around the same time, there is a possibility of the remote, temporarily stored MODEL.spack.yaml to be overwritten before the spack env create call.

The PR

In this PR:

  • We further disambiguate the temporary remote file name with the job id number - for example, access-om3-82974392347.spack.yaml, rather than just access-om3.spack.yaml

@CodeGat CodeGat added type:bug priority:high version:MINOR Doesn't require update to Model Deployment Repositories for:v4 Applies to `v4` labels Mar 18, 2025
@CodeGat CodeGat self-assigned this Mar 18, 2025
@atteggiani atteggiani self-requested a review March 18, 2025 05:47
Copy link

@atteggiani atteggiani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@CodeGat CodeGat merged commit 9703800 into v4 Mar 18, 2025
@CodeGat CodeGat deleted the remote-spack-yaml-run-id-disambiguation branch March 18, 2025 05:52
@CodeGat CodeGat restored the remote-spack-yaml-run-id-disambiguation branch March 18, 2025 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
for:v4 Applies to `v4` priority:high type:bug version:MINOR Doesn't require update to Model Deployment Repositories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants