Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deploy-1-start input in cd.yml to expected-root-spec-name #254

Merged
merged 1 commit into from
Mar 18, 2025

Conversation

CodeGat
Copy link
Member

@CodeGat CodeGat commented Mar 18, 2025

Regression introduced in #248, see https://github.com/ACCESS-NRI/ACCESS-ESM1.6/actions/runs/13915954144

Background

In the linked PR, we updated a input variable to expected-root-spec-name but didn't pass this information on to the cd.yml workflow, only the ci.yml workflow.

In this PR

  • Update the input in cd.yml to the expected one in deploy-1-start.yml.

@CodeGat CodeGat added type:bug priority:blocker version:MINOR Doesn't require update to Model Deployment Repositories for:v4 Applies to `v4` labels Mar 18, 2025
@CodeGat CodeGat self-assigned this Mar 18, 2025
Copy link

@tmcadam tmcadam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@atteggiani atteggiani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@aidanheerdegen
Copy link
Member

In the linked PR, we updated a input variable to expected-root-spec-name but didn't pass this information on to the cd.yml workflow, only the ci.yml workflow

I blame the bad review.

@CodeGat CodeGat merged commit 4f258be into v4 Mar 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
for:v4 Applies to `v4` priority:blocker type:bug version:MINOR Doesn't require update to Model Deployment Repositories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants