!test repro commit: Only commit if checksums differ to the ones on the branch
#139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…is already on the branch
atteggiani
reviewed
Mar 19, 2025
CodeGat
deleted the
138-exit-gracefully-on-identical-checksums-on-branch
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #138
Background
If an earlier commit in a PR branch updates the checksums, and a later
!test repro commitcommand finds that the base branch checksums differ, it will attempt to commit the new checksums. If these new checksums are actually identical to an earlier invocation of!test repro commiton the branch, it will fail to commit and push the changes.This PR checks that changes are actually added before committing and pushing.
This PR
In this PR:
Testing
Tested the
git status --porcelain(and indeed the whole step) locally to verify it is what we want. The--porcelainbit essentially makes the output machine-readable and never changes between versions ofgit, making it useful for scripts.