Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix github workflows #60

Merged
merged 3 commits into from
Mar 3, 2025
Merged

Fix github workflows #60

merged 3 commits into from
Mar 3, 2025

Conversation

atteggiani
Copy link
Collaborator

@atteggiani atteggiani commented Mar 1, 2025

Fixes #54.

  • Fixes CD.yml
  • Fixes CI.yml

This repo's variable PACKAGE_FORMAT has been set to .tar.bz2.

The Verify Conda Build job now succeeds.

Sorry, something went wrong.

@atteggiani atteggiani self-assigned this Mar 1, 2025
@atteggiani atteggiani force-pushed the davide/fix_workflow branch from 9566b13 to a1a761a Compare March 1, 2025 01:54
@atteggiani atteggiani force-pushed the davide/fix_workflow branch from a1a761a to df708bc Compare March 1, 2025 01:59
@atteggiani atteggiani requested review from CodeGat and removed request for CodeGat March 2, 2025 22:22
@CodeGat CodeGat self-requested a review March 2, 2025 22:38
Copy link
Member

@CodeGat CodeGat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good.
You could hypothetically have the Set package path step be an env variable itself, but you'd have to move the env.BUILD_FOLDER up a level into a workflow-level env, which I understand why you didn't!

@atteggiani
Copy link
Collaborator Author

This looks good. You could hypothetically have the Set package path step be an env variable itself, but you'd have to move the env.BUILD_FOLDER up a level into a workflow-level env, which I understand why you didn't!

If you mean having a BUILD_FOLDER and a PACKAGE_PATH env variables at the workflow level, I would be ok with that.
However, I could not set an environment variable dependent on another env variable, something like:

env:
      BUILD_FOLDER: ${{github.workspace}}/build
      PACKAGE_PATH: ${{env.BUILD_FOLDER}}/noarch/*${{vars.PACKAGE_FORMAT}}

because I got complaints about env not being recognised.
Do you know if something like this can be achieved?

@atteggiani atteggiani merged commit 24afba7 into main Mar 3, 2025
3 checks passed
@atteggiani atteggiani deleted the davide/fix_workflow branch March 3, 2025 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done ✅
Development

Successfully merging this pull request may close these issues.

Fix conda build verification step in CI workflow
2 participants