Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conda packaging #26

Merged
merged 11 commits into from
Mar 18, 2025
Merged

Conda packaging #26

merged 11 commits into from
Mar 18, 2025

Conversation

atteggiani
Copy link
Collaborator

Added resources for conda packaging.

The umfile_utils package will be released to the accessnri anaconda channel and will be installable with:

conda install accessnri::umfile_utils

This PR includes CI/CD framework to automatically verify, build and upload the umfile_utils package.

jo-basevi
jo-basevi previously approved these changes Mar 11, 2025
Copy link

@jo-basevi jo-basevi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me! Just a couple insignificant questions - so feel free to resolve

@atteggiani
Copy link
Collaborator Author

atteggiani commented Mar 11, 2025

@jo-basevi
Thank you for your comments. I addressed them in the specific commits.

I also forgot to add a job for a version sanity check.
I did in 29cbca90652fa640e64f837d2c3ae2978e834463

Would you mind having a look at the PR now in its final state?
Thank you!

@atteggiani atteggiani force-pushed the davide/packaging branch 2 times, most recently from 34296e4 to 29cbca9 Compare March 11, 2025 20:40
jo-basevi
jo-basevi previously approved these changes Mar 11, 2025
Copy link

@jo-basevi jo-basevi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me - no major comments.

I wonder if it would be useful using the semver command line tool, or similar, for parsing and comparing versions? Could have logic checking if a tag equals one of semver --increment "major" "$new_tag_name" or semver --increment "minor" "$new_tag_name", etc. I think (?) semver $new_tag_name only returns zero if it's a valid version too.

…release. Added cleanup step for release tags
Copy link

@jo-basevi jo-basevi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall I think the changes looks good to me. I just have another small comment

@atteggiani atteggiani requested a review from jo-basevi March 18, 2025 02:54
Copy link

@jo-basevi jo-basevi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @atteggiani, looks good to me!

@atteggiani atteggiani merged commit 3a37eb0 into main Mar 18, 2025
5 checks passed
@atteggiani atteggiani deleted the davide/packaging branch March 18, 2025 05:42
@atteggiani
Copy link
Collaborator Author

Thank you @jo-basevi for reviewing!
Merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants