Some more tests #16
Merged
Some more tests #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
we need different versions for chdb and clickhouse, to workaround an issue where NULL values are not interpreted as such on import to chdb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Again, mainly to check clickhouse tests in CI (#15).
Issue arose with
unlinkablestest, whose origin was (partially) to do withNULLvalues being converted to the empty string''inchdb(see #17). Introduced a workaround in tests for this, so that we can treat empty strings as though they wereNULL.This manifested as an error with unlinkables chart when we only have
match_probabilityvalues that round to 1, which is an issue upstream.