Bug - count star workaround + Feature pandas frames for ClickhouseAPI #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Basic type inference
now that we can use pandas frames always for input
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does two separate things, that both are needed for passing new test (graph metrics). Apologies for not disentangling.
Count(*)
Due to this issue
count(*)with a filter is not parsed correctly. In Splink such an expression is used in graph metric calculations, which led to an error. As a workaround we intercept + rewrite the SQL.ClickhouseAPI pandas ingestion
The other issue with graph metrics (for
ClickhouseAPIbut notChDBAPI) is that we directly register a pandas dataframe with the API, which was previously disallowed.Now we support this by use of a helper function which creates a table based on pandas typing information. It currently only accepts strings or integer types. It will probably not expand much, leaving more complex typing situations to be sorted by the user by either pre-registering, or using other table input formats.
CI
In for a penny, this actually also does a third thing of correcting the type-hinting CI (see #8) trigger path.