Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Isolate clickhouse / chdb tests #57

Merged
merged 7 commits into from
Jan 2, 2025
Merged

Conversation

ADBond
Copy link
Owner

@ADBond ADBond commented Jan 2, 2025

Although we can run the tests separately for chdb vs clickhouse server (see #7, #28), we cannot actually run the clickhouse tests alone if chdb is not installed.

This PR uses dependency groups to split out chdb as a separate group. This is on by default, but can be opted-out-of (which will be useful when we add python 3.13 (#58), as not available there yet).

@ADBond ADBond merged commit b54d68a into main Jan 2, 2025
16 checks passed
@ADBond ADBond deleted the dev/isolate-clickhouse-tests branch January 2, 2025 10:57
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@da04973). Learn more about missing BASE report.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #57   +/-   ##
=======================================
  Coverage        ?   90.48%           
=======================================
  Files           ?       12           
  Lines           ?      431           
  Branches        ?       32           
=======================================
  Hits            ?      390           
  Misses          ?       24           
  Partials        ?       17           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants