Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More testing #61

Merged
merged 18 commits into from
Jan 2, 2025
Merged

More testing #61

merged 18 commits into from
Jan 2, 2025

Conversation

ADBond
Copy link
Owner

@ADBond ADBond commented Jan 2, 2025

Cover a few edge cases in tests.

More handling of types when registering pandas frames in ClickhouseServerAPI.

@ADBond ADBond added the testing label Jan 2, 2025
Copy link

codecov bot commented Jan 2, 2025

Codecov Report

Attention: Patch coverage is 93.75000% with 1 line in your changes missing coverage. Please review.

Project coverage is 95.59%. Comparing base (44e4765) to head (b753dcc).
Report is 19 commits behind head on main.

Files with missing lines Patch % Lines
splinkclickhouse/clickhouse_server/database_api.py 83.33% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #61      +/-   ##
==========================================
+ Coverage   90.48%   95.59%   +5.10%     
==========================================
  Files          12       12              
  Lines         431      431              
  Branches       32       30       -2     
==========================================
+ Hits          390      412      +22     
+ Misses         24       12      -12     
+ Partials       17        7      -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ADBond ADBond merged commit e1ee439 into main Jan 2, 2025
17 checks passed
@ADBond ADBond deleted the maint/more-testing branch January 2, 2025 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant