De-duplicate OnDiskCorpus #2802
Conversation
|
@domenukk i hope i am going in the right direction. could you have a look at whether this was what you wanted? |
| }); | ||
|
|
||
| // New testcase, we need to save it. | ||
| let mut file_name = file_name_orig.clone(); | ||
| let lockfile_name = format!(".{file_name}.lock"); |
There was a problem hiding this comment.
Ideally we won't need a lockfile anymore for this dude
There was a problem hiding this comment.
Ah wait, you're using the lockfile as a counter now? That would allow us to remove the file when no clients use it anymore, right? Maybe an interesting approach..
There was a problem hiding this comment.
I think this is the implementation that you originally proposed in the issue, or have I misunderstood it?
There was a problem hiding this comment.
Ah right, looks like I have my bright moments...
In that case great! :)
Also, this feature should maybe be optional - it's not needed if testcases rarely get removed or their content changes seldomly.
addresses #2434