Creating a new pull request as I had problems with the previous one. #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ManashRaja it's not a good practice to create a new pull request to correct the problem you had with an old one. The purpose of this task is not to add your name, but to let you learn git by adding your name. So, I suggest you to try reopening the new one. If you are facing problems ask seniors. |
|
All my commits will now come to this pull request. I won't make any new pull request from now on... Also my previous pull request had problems since I reforked this repository.. But I have learnt now. I would continue with this pull request. |
|
@ManashRaja Please improve your commit message see https://www.mediawiki.org/wiki/Gerrit/Commit_message_guidelines |
Added the following line containing my name and github profile link * Manash Pratim Das [ManashRaja](http://github.com/Manashraja) Used the symbol * to create a new bullet entry and generated a hyper link for my github profile. I added this entry in alphabetical order by names.
|
I modified the commit message. |
hargup
added a commit
that referenced
this pull request
Mar 11, 2015
Creating a new pull request as I had problems with the previous one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I faced problems removing the conflicts, so since the previous pull request was closed, therefore I am creating a new pull request.