Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update hip action -- ubuntu 20.04 runner is going away #3034

Merged
merged 2 commits into from
Feb 14, 2025
Merged

update hip action -- ubuntu 20.04 runner is going away #3034

merged 2 commits into from
Feb 14, 2025

Conversation

zingale
Copy link
Member

@zingale zingale commented Feb 12, 2025 •
edited
Loading

this also syncs with amrex
note: we replace std::clamp with amrex::Clamp to work around a compiler bug

PR summary

PR motivation

PR checklist

  • test suite needs to be run on this PR
  • this PR will change answers in the test suite to more than roundoff level
  • all newly-added functions have docstrings as per the coding conventions
  • the CHANGES file has been updated, if appropriate
  • if appropriate, this change is described in the docs

@zingale zingale merged commit 24113bd into AMReX-Astro:development Feb 14, 2025
25 of 26 checks passed
@zingale zingale deleted the update_hip_action branch February 14, 2025 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yut23 yut23 yut23 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zingale @yut23