Add activityIndicator prop support #78
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VincentCATILLON
force-pushed
the
spinner-override
branch
from
53e8a14 to
8d81e17
Compare
|
@alvaromb Can you take a look at my PR ? :) |
|
Hey @VincentCATILLON thanks for your PR, I will take a look, but please it's not necessary to mention all APSL team ;) |
|
Wondering when this is going to be merged, all my jest tests are broken now after installing the library. |
|
3y after, nobody took a look. I'm closing it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds custom activity indicator override to be able to use a custom spinner instead of the default one provided by React Native.
It also fixes #79.
Result and observation
You should be able to use your custom loader (a
Textcomponent inExamplefolder)iOS:
Android:
How to test?
Use
Button.jsexample which provides the new prop