Skip to content

Added ability to override placeholderString #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Added ability to override placeholderString #12

wants to merge 1 commit into from

Conversation

brianjd
Copy link

@brianjd brianjd commented Sep 29, 2016

No description provided.

@alvaromb
Copy link
Collaborator

Hello @brianjd!

Do you feel that setting the locals.label is not enough for your use case?

@brianjd
Copy link
Author

brianjd commented Sep 29, 2016

Hey @alvaromb,

It wasn't. It is pretty common to have placeholder text that doesn't match the label. In my case I needed placeholder text that was a bit more 'assistful'.

alvaromb
alvaromb requested changes Oct 5, 2016
View reviewed changes
Copy link
Collaborator

@alvaromb alvaromb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mind to separate the ternary operators in different lines?

It's very hard to read this way. Otherwise, I'm happy accepting the changes and add this feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alvaromb alvaromb alvaromb requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brianjd @alvaromb