Fix config #701
Merged
Fix config #701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While applying blueprint patches function needs an argument of Bob's directory but not Bob's relative path from 'build' direcotry. Signed-off-by: Sebastian Birunt <[email protected]> Change-Id: I5dabce0071e2de2c96e74a74ab8f244f78fab9e4
If we are setting the value via a plugin,
then the config must have a prompt:
```
config OPTION_X
bool "feature option x"
...
```
Prevent setting non user-settable options. Those will only
get a value from evaluating the 'default' settings on the option.
BREAKING CHANGE: public `set_config()` function from
`config_system` module accepts only `str` type for `value` argument:
```
def set_config(
key: str, value: str, is_user_set: bool = True, source: str = "cmd_line"
) -> None:
```
Change-Id: I44050d65f6f944d9138b40590f4edfb9b3d53c01
Signed-off-by: Sebastian Birunt <[email protected]>
Bump `rules_python` version. With previous (0.18.1) version `bazel coverage` fails intermittently with `No source for code:`. Signed-off-by: Sebastian Birunt <[email protected]> Change-Id: If182e1011188eeeea039bf86eb6874c856301f39
LCOV of commit
|
a-khabarov
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change fixes config inconsistency. It might happen as public
set_configofconfig_systemmodule is allowed to set configs who are not user-settable.This is BREAKING CHANGE as API of
set_configchanges to acceptstrtype only forvalueargument.