Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove TDB_EXTERNAL_NO_RBP and FILESYSTEM_NO_RBP from KVStore docs #1440

Merged
merged 1 commit into from
May 20, 2021

Conversation

harmut01
Copy link
Contributor

@harmut01 harmut01 commented Mar 31, 2021

Preceeding PR: ARMmbed/mbed-os#14490

NO_RBP (no rollback protection) is intended to not require an internal
TDB, however, DeviceKey, which we use to derive SecureStore's
encryption key, still does. Currently, no internal TDB is created with
these two configurations, meaning there's no way to store the DeviceKey
and SecureStore doesn't work.

Update the documentation to reflect these changes.

@harmut01 harmut01 requested a review from Patater April 1, 2021 10:28
@harmut01 harmut01 force-pushed the securestore_update branch 5 times, most recently from cb32703 to 8668e23 Compare April 8, 2021 10:16
NO_RBP (no rollback protection) is intended to not require an internal
TDB, however, DeviceKey, which we use to derive SecureStore's
encryption key, still does. Currently, no internal TDB is created with
these two configurations, meaning there's no way to store the DeviceKey
and SecureStore doesn't work.

Update the documentation to reflect these changes.
@harmut01 harmut01 force-pushed the securestore_update branch from 8668e23 to 5a62d4e Compare April 8, 2021 11:00
@harmut01 harmut01 requested a review from LDong-Arm April 8, 2021 11:30
Copy link
Contributor

@LDong-Arm LDong-Arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@LDong-Arm LDong-Arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we switched from removal to deprecation, the documentation clean-up is still valid - we just retained the config and code with deprecation notices.

So this PR still looks good to me.

@LDong-Arm
Copy link
Contributor

@donatieng Could you please merge this? It's part of the ongoing release, thanks

@donatieng donatieng merged commit bfa7be4 into ARMmbed:development May 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants