-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove TDB_EXTERNAL_NO_RBP and FILESYSTEM_NO_RBP from KVStore docs #1440
Conversation
cb32703
to
8668e23
Compare
NO_RBP (no rollback protection) is intended to not require an internal TDB, however, DeviceKey, which we use to derive SecureStore's encryption key, still does. Currently, no internal TDB is created with these two configurations, meaning there's no way to store the DeviceKey and SecureStore doesn't work. Update the documentation to reflect these changes.
8668e23
to
5a62d4e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As we switched from removal to deprecation, the documentation clean-up is still valid - we just retained the config and code with deprecation notices.
So this PR still looks good to me.
@donatieng Could you please merge this? It's part of the ongoing release, thanks |
Preceeding PR: ARMmbed/mbed-os#14490
NO_RBP (no rollback protection) is intended to not require an internal
TDB, however, DeviceKey, which we use to derive SecureStore's
encryption key, still does. Currently, no internal TDB is created with
these two configurations, meaning there's no way to store the DeviceKey
and SecureStore doesn't work.
Update the documentation to reflect these changes.