Skip to content

ESP8266: Convert to Chrono #12433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 13, 2020
Merged

ESP8266: Convert to Chrono #12433

merged 1 commit into from
May 13, 2020

Conversation

kjbracey
Copy link
Contributor

Summary of changes

Convert ESP8266 driver wrapper to use new APIs from #12425.

Impact of changes

Eliminate use of deprecated APIs

Migration actions required

n/a

Documentation

None


Pull request type

[] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[X] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[X] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers


@ciarmcom ciarmcom requested review from a team February 14, 2020 10:00
@ciarmcom
Copy link
Member

@kjbracey-arm, thank you for your changes.
@ARMmbed/mbed-os-ipcore @ARMmbed/mbed-os-maintainers please review.

@adbridge
Copy link
Contributor

@kjbracey-arm what is the state of this now ?

@kjbracey
Copy link
Contributor Author

Waiting for #12425, like all the other Chrono PRs. Added the missing label.

@0xc0170
Copy link
Contributor

0xc0170 commented May 8, 2020

I restarted travis, however it failed (not certain due to rebase or there is an error in this PR) , so if again, please review

@kjbracey
Copy link
Contributor Author

CI started

@mbed-ci
Copy link

mbed-ci commented May 11, 2020

Test run: SUCCESS

Summary: 6 of 6 test jobs passed
Build number : 1
Build artifacts

@mergify mergify bot removed the ready for merge label May 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants