Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the vulnerabilty of #15462 issue #15474

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

fireknight-hJ
Copy link

Summary of changes

Set the stateRx variable to HCI_RX_STATE_IDLE when an invalid HCI packet type is detected, to prevent overflow in the hdrRx buffer.

Impact of changes

Migration actions required

Documentation


Pull request type

[X] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[X] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers


@0xc0170
Copy link
Contributor

0xc0170 commented Dec 8, 2023

@fireknight-hJ Thanks for the patch, cna you please remove the first commit (merge to your branch, instead do a rebase - there should be only one commit here in this pull request - on your branch).

@0xc0170 0xc0170 added needs: review needs: work release-type: patch Indentifies a PR as containing just a patch and removed needs: review labels Dec 8, 2023
@fireknight-hJ fireknight-hJ force-pushed the master branch 2 times, most recently from b87e148 to 3f82313 Compare December 10, 2023 13:46
@fireknight-hJ
Copy link
Author

@fireknight-hJ Thanks for the patch, cna you please remove the first commit (merge to your branch, instead do a rebase - there should be only one commit here in this pull request - on your branch).

Done,Please let me know if there's anything else needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs: review release-type: patch Indentifies a PR as containing just a patch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants