Use parenthesis to clarify the precedence of operators instead of rel… #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ying on non-uniform spacing.
|
Hi @LaurentLouf, sorry about the unfortunate timing, but we're currently moving the block devices into the mbed-os tree: The prs on this repo will be frozen while this is happening, and then you can either open a pr on mbed-os, or we'll look at moving this pr over when we go through marking the external repositories as obsolete. |
|
Ok no worries, this really is just some nit-picking, it only helps with readability. |
|
Yeah thanks for taking the time to create an issue about it. |
|
Hi @LaurentLouf , together with the change that @geky mentioned, the SPIFBlockDevice code will be going through few changes - the change you suggested will probably no longer be relevant. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ying on non-uniform spacing.
Maybe I'm a bit of a nitpicker, but relying on the precedence of operators like that make me wonder what was going on for a few minutes. Since it only costs a few parenthesis and spaces to avoid that, I fixed it.