[26] Fix public/scoped package publishing #27
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomStrepsil
changed the title
TomStrepsil
commented
Feb 27, 2025
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "web-toggle-point-serve-example", | |||
| "version": "0.2.0", | |||
| "version": "0.2.3", | |||
There was a problem hiding this comment.
See here for explanation of 0->3 bump.
asos-danielc
approved these changes
Mar 6, 2025
TomStrepsil
added a commit
to TomStrepsil/web-toggle-point
that referenced
this pull request
Apr 10, 2025
* update workflows * version * typo * update chromium linux snaps * versions for serve update * package.json repository field * update root package.lock * bugs & directories/doc fields * fix changelog --------- Co-authored-by: Tom Pereira <[email protected]>
asos-dominicjomaa
pushed a commit
that referenced
this pull request
Jul 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
26
Details
Fixing publishing pipline, as per NPM and GitHub documentation, mirroring prior art from @asos/snyker.
For good measure, updated all
package.jsonto have a link back to the repository, again as per @asos/snkyer. Unsure if needed for NPM packages, but it's suggested for GitHub Packages and probably good metadata to have in NPM in any case.Whilst there, also inspired by
@asos/snyker, added abugsanddirectories/docsection, again to help link packages back to the code repository.As per #21 - some unexpected changes to playwright snapshots found, blocking CI. This PR temporarily updates these, whilst waiting on #29
CheckList
main.