-
-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for lists in query2 #50
Conversation
5a59ffa
to
9d2ee32
Compare
9d2ee32
to
b10e52a
Compare
Codecov Report
@@ Coverage Diff @@
## master #50 +/- ##
==========================================
+ Coverage 95.86% 96.21% +0.34%
==========================================
Files 30 29 -1
Lines 1136 1188 +52
Branches 168 183 +15
==========================================
+ Hits 1089 1143 +54
+ Misses 22 19 -3
- Partials 25 26 +1
Continue to review full report at Codecov.
|
I think |
Also, weird that AppVeyor fails. But doesn't seem to be caused by your commits. |
limit is even more confusing IMO because it doesn't specify what it's actually limiting. |
Looks like me merging #55 created some conflicts, could you look into fixing them @johan-bjareholt and I'll implement |
… test, improved error handling in test_query2
1b26510
to
88d8d94
Compare
"Some" conflicts was an understatement... Seems to work now atleast, but each individual commit is likely broken now so probably better to just sqash it all before merge later. |
Reverted to previous limit_events |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, if you can fix the weird limit bug in CI.
Just a question, why remove the spaces around the =
assignments in the queries? I find it more difficult to read that way.
Mistake during the rebase, will fix |
4663852
to
353a6e1
Compare
Fixed |
28a2a79
to
e6ad952
Compare
Improved coverage now a bit well too (99% on query2.py), merging |
aw-webui needs these changes for compatibility ActivityWatch/aw-webui#66