forked from AdaGold/rails-zoo
-
Notifications
You must be signed in to change notification settings - Fork 31
Janice's Zoo/RSVP app #30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
janicewilson
wants to merge
32
commits into
Ada-C7:master
Choose a base branch
from
janicewilson:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d and added content to the index view.
…ociated with controller action update. Modifed the rsvp_form, enabling certain fields hidden depending upon the HTTP verb.
…conditional for an optional yield. Last push. Lots of items unresolved/unfinished including a nascent attempt to incorporate a multi-page form. I've also made an error whereby after updating an object, the changes are not reflected in the Edit Form, although changes remain persistent in the Show view. This could be a quirk with the selects. Haven't yet explored.
Apologies! I think I may have accidentally forked AdaGold. Wasn't certain of the most efficacious means to reconcile the circumstance. Just let me knopw if you need me to resubmit! |
Rails ZooWhat We're Looking For
|
Noted re .DS_Store. (I have been woefully under-utilizing .gitignore.) Thanks! Hoping deploy after Heroku!
On Apr 5, 2017, at 10:50, Kari Bancroft <[email protected]> wrote:
Rails Zoo
What We're Looking For
Feature Feedback
Appropriate Git usage with no extraneous files checked in Yes - though the .DS_Store file is checked in so add this to your .gitignore file in the future
Answered comprehension questions Yes - love the way you describe the request cycle :-)
Naming conventions: controller is plural, model is singular Yes - One style standard in Rails is if you have to create a Rails method with no contents (like in your StaticController) then you create the methods on a single line like def travel; end
Overall Looks good! Excited for your to get some use out of this :-)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <#30 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ADyUb9qxDZLWqvRIoNDPjoJBCfuudMzKks5rs9R7gaJpZM4MxLV2>.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rails Zoo
Congratulations! You're submitting your assignment!
Comprehension Questions
match
and I'm uncertain whether use of such is good/best practice.