Skip to content

Janice's Zoo/RSVP app #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 32 commits into
base: master
Choose a base branch
from
Open

Janice's Zoo/RSVP app #30

wants to merge 32 commits into from

Conversation

janicewilson
Copy link

Rails Zoo

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
Describe in your own words the Rails request/response cycle for viewing an animals detail page I suppose the equivalent would be the reservation_path(reservation.id). User clicks a link to dig into the particulars of a reservation. As a result, the HTTP verb GET is sent hurtling toward Routes. Routes then determines which Controller get the verb baton. The Controller then asks the View matching the action associated with the verb baton to serve up the visuals. The View serves up the visual for the Controller, after which the Controller then serves up that visual for the user.
Describe one area of Rails that you gained more clarity on with this assignment Hmmm. Maybe best uses for partials. Perhaps a better understanding that there doesn't exist only one Controller and that each Controller has a specialty.
Is there a specific piece of code you'd like more feedback on? Although I haven't yet had the issue in this project, I still remain curious (as per my request for feedback on TaskList) re best practices when routing the same HTTP verb to more than one action. In TaskList, I utilized match and I'm uncertain whether use of such is good/best practice.
What is one aspect of this project that surprised you? Still getting accustomed to the idea that Ruby can be used anywhere. Which is pretty cool.

…ociated with controller action update. Modifed the rsvp_form, enabling certain fields hidden depending upon the HTTP verb.
…conditional for an optional yield. Last push. Lots of items unresolved/unfinished including a nascent attempt to incorporate a multi-page form. I've also made an error whereby after updating an object, the changes are not reflected in the Edit Form, although changes remain persistent in the Show view. This could be a quirk with the selects. Haven't yet explored.
@janicewilson
Copy link
Author

Apologies! I think I may have accidentally forked AdaGold. Wasn't certain of the most efficacious means to reconcile the circumstance. Just let me knopw if you need me to resubmit!

@kariabancroft
Copy link

Rails Zoo

What We're Looking For

Feature Feedback
Appropriate Git usage with no extraneous files checked in Yes - though the .DS_Store file is checked in so add this to your .gitignore file in the future
Answered comprehension questions Yes - love the way you describe the request cycle :-)
Naming conventions: controller is plural, model is singular Yes - One style standard in Rails is if you have to create a Rails method with no contents (like in your StaticController) then you create the methods on a single line like def travel; end
Overall Looks good! Excited for your to get some use out of this :-)

@janicewilson
Copy link
Author

janicewilson commented Apr 5, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants