-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Carets - Maria McGrew - Api Muncher #34
base: master
Are you sure you want to change the base?
Conversation
…cipes method passing
API MuncherWhat We're Looking For
|
lib/edamam_api_wrapper.rb
Outdated
|
||
response = HTTParty.get(url) | ||
if response | ||
image = URI.encode(response[0]["image"]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you also need to do:
if response[0]
end | ||
end | ||
|
||
it "returns an error if it has a bad request" do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test throws an error because of the thing I noted in the wrapper.
end | ||
|
||
def index | ||
@recipes = EdamamApiWrapper.list_recipes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should take an argument from params!
API Muncher
Congratulations! You're submitting your assignment!
Comprehension Questions