Pipes - Unicorns - LoreStore (bEtsy)

[anemonekey]

bEtsy

Congratulations! You're submitting your assignment! These comprehension questions should be answered by all members of your team, not by a single teammate.

Comprehension Questions

Question	Answer
How did your team break up the work to be done?	We first broke up work by Model and then by Controller for testing as well as implementation and views.
How did your team utilize git to collaborate?	We used branches when we worked alone and merged when we worked together.
What did your group do to try to keep your code DRY while many people collaborated on it?	We added helper methods and partials to keep our code as DRY as possible.
What was a technical challenge that you faced as a group?	Implementing the shopping cart was tricky. It was difficult because it involved a combination of Controllers and session. We resolved it through Trello.
What was a team/personal challenge that you faced as a group?	We tried to utilize the principles of test-driven development and did most of our tests first. Thus, we felt very behind other groups initially, but we ended up having more time than we expected.
What could your team have done better?	There were cases wherein we didn't use designs that we already created and also when one person worked on the code another person worked on. This could be improved with more upfront design work and more active communication.
What was your application's ERD? (include a link)	on Trello! (https://trello-attachments.s3.amazonaws.com/59e6556b2364a8e06a95e2d3/59f3b2da101f9916ba0b179c/4174472bb5f30f77ef464c90f1d9ae2b/LoreStore_-_Page_1.png)
What is your Trello URL?	https://trello.com/b/KxYByMqu/lorestore
What is the Heroku URL of your deployed application?	https://lorestore.herokuapp.com/

[PilgrimMemoirs]

bEtsy

What We're Looking For

Feature	Feedback
Baseline
Appropriate Git Usage with all members contributing	Well Done
Answered comprehension questions	Well Done - Nice Reflection
Trello board is created and utilized in project management	Well Done - I suggest keeping names on all cards to make it easier to know who to go to if there's a question about code from that feature.
Heroku instance is online	Well Done
General
Nested routes follow RESTful conventions	Well Done - There are a few custom routes that are not following RESTful conventions.
oAuth used for User authentication	Well Done
Functionality restricted based on user roles	Well Done
Products can be added and removed from cart	Well Done
Users can view past orders	Well Done
Merchants can add, edit and view their products	Well Done
Errors are reported to the user	Well Done
Order Functionality
Reduces products' inventory	Well Done
Cannot order products that are out of stock	Well Done
Changes order state	Mostly Good - Does add a random, surprise item after checking out
Clears current cart	Well Done
Database
ERD includes all necessary tables and relationships	Well Done
Table relationships	Well Done
Models
Validation rules for Models	Well done - nice use for quantity_check in order
Business logic is in the models	Well Done
Controllers
Controller Filters used to DRY up controller code	Well Done
Testing	166 tests, 390 assertions, 1 failures, 2 errors, 0 skips
Model Testing	Mostly Good - Merchant missing tests for custom methods
Controller Testing	Well Done
Session Testing	Well Done - Nice organization of tests for logged in vs guest
SimpleCov at 90% for controller and model tests	Close - 85.93%
Front-end
The app is styled to create an attractive user interface	Well Done - Jaaaaaazzy! Especially love the merchant dashboard for knowing the status of everything, so well thought out!
The app layout uses Foundation's Grid	Well Done
Content is organized with HTML5 semantic tags	Well Done
CSS is DRY	Mostly Good - if using variables for colors, set in application.css then use variable wherever else needed. There are a couple rulesets that are the same, even within the same file, where multiple selectors should have been used.
Overall
	This submission shows you were all able work together well and produce a project that has met expectations. Nice Work!
	More specific feedback will be given as inline comments in the submitted PR code.

IMPORTANT: Whoever submitted the PR (and thus will get the notification about this feedback) should share this with their teammates.