Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jan Edrozo | Carets #31

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Jan Edrozo | Carets #31

wants to merge 12 commits into from

Conversation

JNEdrozo
Copy link

@JNEdrozo JNEdrozo commented Nov 17, 2017

JS Scrabble

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
What patterns were you able to use from your Ruby knowledge to apply to JavaScript? Design patterns I've implemented in both Ruby and JS scrabble versions involve encapsulation, leveraging helper methods to promote modularity, and using enumerables. Specifically, in JS Scrabble module, the score() method uses two helper methods (splitChars and totalScore) to calculate a word's score and, its highestScoreFrom() method uses the reduce method to iterate over an array of words.
What was a challenge you were able to overcome on this assignment? One challenge was learning how to implement "this". After working on JS Scrabble, I learned that using "this" not only invokes self, but can also serve as a way of namespacing; connecting an object to a behavior. For example, in the Player's highestWordScore() method, initially, I tried calling the highestScoringWord() method using "Scrabble.highestScoringWord()", but JS could not recognize it as a function when called inside of Scrabble.score(). The workaround was to use "this"; which was handy to note after linter pointed that out!
What is your favorite thing about learning a new programming language? During this project, I enjoyed being able to better Google to learn a new language. It was much easier/faster to navigate different resources now that I have a larger vocabulary and can hone in on more specific terms to help me solve a problem.
What is your least favorite thing about learning a new programming language? Navigating the nuances of syntax, style guides and understanding the why's behind best practices
Do you have any recommendations on how we could improve this project for the next cohort? Maybe having optional tests set up?

@tildeee
Copy link

tildeee commented Nov 27, 2017

JS Scrabble

What We're Looking For

Feature Feedback
Core Requirements
Git hygiene x
Comprehension questions x
General
score calculates score, has appropriate params and return value x
highestScoreFrom calculates highest scoring word, has appropriate params and return value x
Player object
Has name and plays properties x
Has play, totalScore, hasWon functions x
Has highestScoringWord and highestWordScore functions x
Overall

You implemented a really good function splitChars()! There's a built-in JS function that does that. In Google Chrome's Dev tools, in the console, run the line "abcd".split("");!

Good job overall!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants