Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Amy Cash - Pipes - JS Scrabble #38

Open
wants to merge 28 commits into
base: master
Choose a base branch
from
Open

Amy Cash - Pipes - JS Scrabble #38

wants to merge 28 commits into from

Conversation

cashmonger
Copy link

JS Scrabble

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
What patterns were you able to use from your Ruby knowledge to apply to JavaScript? And/Or Logic, If/Else, iterating over arrays
What was a challenge you were able to overcome on this assignment? Figuring out how to use 'this' correctly.
What is your favorite thing about learning a new programming language? It presented a new way to think about 'old' concepts (is 3 months old, old?). That is, how the parts of the language work together to solve a problem.
What is your least favorite thing about learning a new programming language? Kind of the flip side to the previous answer -- it was hard to remember that some of the same concepts had different syntax. Also {{{{{BRACKETS!}}}}}
Do you have any recommendations on how we could improve this project for the next cohort? Not really. I think it's a good idea to go back and revisit projects we did with Ruby.

@PilgrimMemoirs
Copy link

JS Scrabble

What We're Looking For

Feature Feedback
Core Requirements
Git hygiene Well Done
Comprehension questions Well Done
General
score calculates score, has appropriate params and return value Well Done - nice use of throwing exceptions
highestScoreFrom calculates highest scoring word, has appropriate params and return value Well Done - nice use of breaking functionality between functions
Player object
Has name and plays properties Well Done
Has play, totalScore, hasWon functions Well Done
Has highestScoringWord and highestWordScore functions Well Done - Nice use of utilizing functionality of Scrabble
Overall
There is repeated code between Player's play function and Scrabble's score function to throw errors - how could you go about DRYing that up?
Submission meets project requirements, great work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants