Skip to content

fix: memory leak in SMTP server Get_Message function #392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

younes-io
Copy link
Contributor

Found a small memory leak in the SMTP server: Get_Message creates a socket copy but forgets to free it. The actual socket is fine (it's ref-counted), just the wrapper that leaks.

Added the missing Net.Free call + exception handler to clean up properly. Nothing fancy, just following the same cleanup pattern used elsewhere in AWS.

@CLAassistant
Copy link

CLAassistant commented May 31, 2025

CLA assistant check
All committers have signed the CLA.

@younes-io
Copy link
Contributor Author

@TurboGit : could you please take a look at this? any other maintainers for this project?

@ogorodnik ogorodnik self-requested a review June 13, 2025 14:40
@ogorodnik
Copy link
Contributor

@younes-io Thank you for correcting this.

@younes-io
Copy link
Contributor Author

@ogorodnik : I see the code on master but this PR is not merged..

@ogorodnik
Copy link
Contributor

@younes-io Hello, we moved your patch to our repository, which mirrors the code here. I'll close this PR if GitHub does not close it automatically (in general, it does when it sees the MR copied).

@younes-io
Copy link
Contributor Author

younes-io commented Jun 15, 2025

@younes-io Hello, we moved your patch to our repository, which mirrors the code here. I'll close this PR if GitHub does not close it automatically (in general, it does when it sees the MR copied).

@ogorodnik alright, thank you for the feedback. So, in the future, I can keep contributing to this repo, right? or is there some other repo?

@ogorodnik
Copy link
Contributor

@younes-io You can create MRs here, we will take care of them.

1 similar comment
@ogorodnik
Copy link
Contributor

@younes-io You can create MRs here, we will take care of them.

@ogorodnik ogorodnik closed this Jun 16, 2025
@younes-io
Copy link
Contributor Author

@younes-io You can create MRs here, we will take care of them.

understood, thanks

@younes-io younes-io deleted the fix/smtp-server-memory-leak branch June 16, 2025 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants