Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolve punycode deprecation warning from jest-environment-jsdom #1893

Merged
merged 1 commit into from
Jan 21, 2025

Conversation

bchew
Copy link
Member

@bchew bchew commented Jan 21, 2025

Description

Resolve punycode deprecation warning from jest-environment-jsdom

Does this PR introduce a breaking change?

  • Yes
  • No

Manual testing step?

Screenshots (if appropriate):

@bchew bchew force-pushed the jest-jsdom-punycode branch from c83653a to a638113 Compare January 21, 2025 03:54
Copy link

codecov bot commented Jan 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.73%. Comparing base (e971e1c) to head (a638113).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1893   +/-   ##
=======================================
  Coverage   99.73%   99.73%           
=======================================
  Files          94       94           
  Lines        1868     1868           
  Branches      552      552           
=======================================
  Hits         1863     1863           
  Misses          5        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bchew bchew requested a review from romi-h January 21, 2025 04:00
@xiaofan2406 xiaofan2406 merged commit 49f3ed7 into master Jan 21, 2025
11 checks passed
@xiaofan2406 xiaofan2406 deleted the jest-jsdom-punycode branch January 21, 2025 04:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants