Implement DECALN control sequence #27
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it easy to get more information from tests, without changing `test/test_common.h` and recompiling. If the `CK_VERBOSITY` environment variable is not set, the default is the same as it was, i.e. `CK_NORMAL`.
This control sequence is used by vttest and is present since VT100.
|
I've noticed some of these changes, for example resetting margins and moving the cursor to the origin appear often in implementations. Before making more changes, I'll see if I can factor those repetitive parts out. |
|
This is huge! Thanks for working on this.
How "common" is the sequences used in vttest? I think we should aim for it, but if there're some obscure sequences that are too hard to implement, feel free to skip them. (We should keep a list of known unimplemented sequences somewhere in the doc) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm trying to get libtsm to properly execute the vttest tests. The missing DECALN sequence is simply the first issue I ran into with the first tests.
I have implemented the behavior by reading the DEC STD 070 Video Systems Reference Manual and matching the output with that of xterm.
I plan to work my way through all the tests in
vttest, do you think that's worthwhile?