-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Agents SDK instrumentation. #854
Conversation
…trumentation Co-Authored-By: [email protected] <[email protected]>
…trumentation Co-Authored-By: [email protected] <[email protected]>
…ion of version of values into semantic types.
…neration tooling. increased test coverage
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @tcdent for the PR! This is helpful in moving towards a more stable instrumentation for the OpenAI provider and Agents framework.
I have requested some changes primarily on the semantic conventions being used to record the attributes. This would prevent duplication of data and provide an ordered structure of extracting data from queries in the backend.
@the-praxs Did you run this? Post your script and output below. |
https://gist.github.com/the-praxs/73fe232afb46c6cccb110dd4de9db0ba |
…nts exclusively for now.
Codecov ReportAttention: Patch coverage is 📢 Thoughts on this report? Let us know! |
Testing results here - https://gist.github.com/the-praxs/251d08f2aca7810759c3b954305f5850 |
Tested streaming with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM AND YOLO
* Log deeplink to trace on AgentOps dashboard. * Test coverage, type checking. * Get app_url from config. * Don't format trace_id in the URL as a UUID, just a hex string.
Thus implementation demonstrates a sustainable pattern for all instrumentation that gets included in AgentOps.
Response
objects fromopenai-agents
and completions & responses fromopenai
span_name
sagents.function
should be something likeagents.tool.<tool_name>
agents.response
should have the agent nameopenai_agents
hands off to tracing; lots of things get categorized asresponse
, but it works much better now.This will be applied in a new PR.instrumentation.openai
is incomplete. I created it to be able to instrument responses api calls, but ended up incorporating that into theinstrumentation.openai_agents
.