feat: upgrade v7-board and test it #10516

Chris-Hibbert · 2024-11-18T19:16:28Z

Description

Upgrade v7-board.

Security Considerations

The Board is a critical vat.

Scaling Considerations

v7-Board is consuming more resources than it should. restarting it should clean up a fair amount of space. ...checking

Documentation Considerations

None

Testing Considerations

Verify that the board doesn't lose anything.

Upgrade Considerations

Can go out in Upgrade 19.

dckc

It seems "restarting it should clean up a fair amount of space." is not mentioned in the test plan of #10394

Would you please clarify that this is on purpose? Do we have other plans (mainfork?) for testing that?

dckc · 2024-11-18T20:01:27Z

packages/vats/src/proposals/upgrade-board-proposal.js

+
+  const { adminNode } = await E(vatStore).get('board');
+
+  await E(adminNode).upgrade(boardBundleCap, {});


I suggest logging completion of upgradeBoard.

packages/vats/src/proposals/testUpgradedBoard.js

Chris-Hibbert · 2024-11-18T20:55:54Z

Would you please clarify that this is on purpose? Do we have other plans (mainfork?) for testing that?

Sorry, I wrote "restarting it should clean up a fair amount of space. ...checking", meaning that I intend to see if approaches like I used in #9595 would show some improvement. I'll do that next.

Chris-Hibbert · 2024-11-19T18:17:28Z

Well I get a count of 422 before in a3p-integration, and 432 after, using a query like this (with vatID = 7).

    sql.get([`SELECT COUNT(*) from kvStore WHERE key LIKE '${vatId}.c.%'`]);

I don't know what objects are soaking up space on mainnet, but they're not in evidence here.

@mhofman @warner Is there anything else worth checking in a3p-integration?

cloudflare-workers-and-pages · 2024-11-26T01:26:04Z

Deploying agoric-sdk with Cloudflare Pages

Latest commit:	`a3e6f86`
Status:	✅ Deploy successful!
Preview URL:	https://44030cb1.agoric-sdk.pages.dev
Branch Preview URL:	https://10394-board.agoric-sdk.pages.dev

View logs

Chris-Hibbert · 2024-11-26T22:38:24Z

Well, we did a bunch of measuring, and ran a lot of tests, but were unable to replicate the issue from MainNet. The code in a3p-integration stubbornly refused to allocate and retain the excess objects that we see on mainNet, so the tests don't show that this upgrade reclaims the space.

The requirement to upgrade the vat is independent of addressing this issue, so I'd like to move forward with the upgrade, and return to the other issue when we have a better theory about how to replicate the problem.

dckc · 2024-11-26T22:41:57Z

retain the excess objects that we see on mainNet

I asked about the relevant issue for that. You suggested that...

maybe report VOAwareWeakMap/Set collection stats from BOYD #8053

... is in the neighborhood. Yes, I see it discusses a passStyleOf memoization cache.

dckc

I'm not confident that I'm reading this correctly.

A bit of voice discussion might help.

dckc · 2024-11-26T22:43:29Z

a3p-integration/proposals/p:upgrade-19/eval.sh

+cp /usr/src/upgrade-test-scripts/eval_submission.js .
+
+#echo RUNNING  ./eval_submission.js
+#./eval_submission.js


Is execution of ./eval_submission.js commented out on purpose?

Nope. I cleaned up other parts of the file while I was here.

dckc · 2024-11-26T22:47:06Z

packages/vats/src/proposals/upgrade-board-proposal.js

+  const same =
+    idsBefore.length === idsAfter.length &&
+    idsBefore.every((element, index) => element === idsAfter[index]);
+  assert(same, 'keys must stay the same');


Is this a test assertion? Or is it intended to run in production?

If it fails, we know there's a problem, but the damage is already done, right?

The same proposal with this assertion will run in production as on our test networks. If it succeeds in tests, we'll have confidence that it will succeed in production.

Would you suggest logging the result rather than asserting it?

So it's in prod by design. Ok.

dckc · 2024-11-26T22:48:44Z

a3p-integration/proposals/p:upgrade-19/upgradedBoard.test.js

+import { evalBundles } from '@agoric/synthetic-chain';
+
+test('test upgraded board', async t => {
+  await evalBundles('submission');


what bundles does this refer to? a comment might help readers like me that don't have this API swapped in

dckc · 2024-11-26T22:50:30Z

packages/builders/scripts/testing/replace-feeDistributor-short.js

@@ -3,7 +3,7 @@ import { getManifestForReplaceFeeDistributor } from '@agoric/inter-protocol/src/

 /** @type {import('@agoric/deploy-script-support/src/externalTypes.js').CoreEvalBuilder} */
 export const defaultProposalBuilder = async (_, opts) => {
-  console.log('OPTS', opts);
+  console.log('feeDist  OPTS', opts);


what's this -short.js file for? a @file comment would be nifty

added a comment.

dckc · 2024-11-26T22:52:30Z

packages/vats/src/proposals/testUpgradedBoard.js

+  const thing1Id = await E(board).getId(thing1);
+  assert(thing1Id.match(/^board0[0-9]+$/));
+
+  // /////// can we retrieve something stored long ago?  ////////


what is the thing stored long ago that we're retrieving?

The brand. The comment was displaced from its subject.

dckc

OK. I get it now. Looks good.

Chris-Hibbert added contract-upgrade force:integration Force integration tests to run on PR labels Nov 18, 2024

Chris-Hibbert self-assigned this Nov 18, 2024

Chris-Hibbert requested a review from a team as a code owner November 18, 2024 19:16

Chris-Hibbert requested review from AgoricTriage and dckc November 18, 2024 19:16

dckc reviewed Nov 18, 2024

View reviewed changes

Chris-Hibbert requested a review from dckc November 26, 2024 22:39

dckc reviewed Nov 26, 2024

View reviewed changes

dckc approved these changes Nov 27, 2024

View reviewed changes

Chris-Hibbert added the automerge:squash Automatically squash merge label Nov 27, 2024

Chris-Hibbert added 7 commits November 27, 2024 11:40

feat: upgrade v7-board and test it

4e39166

feat: run test-upgraded-board.js in p:upgrade-19, not upgrade.go

efdf232

chore: clarify feeDistributor messages

dcfc822

chore: verify that the boards list of keys doesn't change

e80ed6b

test: reinstate corrected proposal submissions

2cde502

chore: better comments and cleanups

4cf4af6

chore: drop a space to make prettier happy

cf00b9a

Chris-Hibbert force-pushed the 10394-board branch from babdddd to cf00b9a Compare November 27, 2024 19:45

Chris-Hibbert and others added 3 commits November 27, 2024 16:05

chore: since upgrade-paRegistry is not in u18, move it to u19

00ca9e4

Merge branch 'master' into 10394-board

ede0053

Merge branch 'master' into 10394-board

a3e6f86

mergify bot merged commit d8a109e into master Nov 28, 2024
81 checks passed

mergify bot deleted the 10394-board branch November 28, 2024 02:02

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: upgrade v7-board and test it #10516

feat: upgrade v7-board and test it #10516

Chris-Hibbert commented Nov 18, 2024

dckc left a comment

dckc Nov 18, 2024

Chris-Hibbert Nov 26, 2024

Chris-Hibbert commented Nov 18, 2024

Chris-Hibbert commented Nov 19, 2024

cloudflare-workers-and-pages bot commented Nov 26, 2024 •

edited

Loading

Chris-Hibbert commented Nov 26, 2024

dckc commented Nov 26, 2024

dckc left a comment

dckc Nov 26, 2024

Chris-Hibbert Nov 27, 2024

dckc Nov 26, 2024

Chris-Hibbert Nov 27, 2024

dckc Nov 27, 2024

dckc Nov 26, 2024

Chris-Hibbert Nov 27, 2024

dckc Nov 26, 2024

Chris-Hibbert Nov 27, 2024

dckc Nov 26, 2024

Chris-Hibbert Nov 27, 2024

dckc left a comment


		const { adminNode } = await E(vatStore).get('board');

		await E(adminNode).upgrade(boardBundleCap, {});

feat: upgrade v7-board and test it #10516

feat: upgrade v7-board and test it #10516

Conversation

Chris-Hibbert commented Nov 18, 2024

Description

Security Considerations

Scaling Considerations

Documentation Considerations

Testing Considerations

Upgrade Considerations

dckc left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Chris-Hibbert commented Nov 18, 2024

Chris-Hibbert commented Nov 19, 2024

cloudflare-workers-and-pages bot commented Nov 26, 2024 • edited Loading

Deploying agoric-sdk with Cloudflare Pages

Chris-Hibbert commented Nov 26, 2024

dckc commented Nov 26, 2024

dckc left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dckc left a comment

Choose a reason for hiding this comment

cloudflare-workers-and-pages bot commented Nov 26, 2024 •

edited

Loading