Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coral: Mark plaintext as insecure and let user confirm choice when adding new Cluster #2853

Merged
merged 3 commits into from
Mar 24, 2025

Conversation

programmiri
Copy link
Contributor

@programmiri programmiri commented Mar 24, 2025

Linked issue

Resolves: https://aiven.atlassian.net/browse/GOV-981

What kind of change does this PR introduce?

  • Bug fix
  • New feature
  • Refactor
  • Docs update
  • CI update

This PR

Changes to the "Add new Cluster" form:

  • adds SSL as default protocol

  • marks PLAINTEXT as not recommended

  • if user chooses PLAINTEXT, shows warning

  • if user wants to submit with PLAINTEXT, shows confirmation modal where user needs to confirm this choice to add a new Cluster

  • updates the copy in Angular to be consistent

Recording

recording.mov

@programmiri programmiri self-assigned this Mar 24, 2025
@programmiri programmiri changed the title Mark plaintext as insecure and let user confirm choice coral: Mark plaintext as insecure and let user confirm choice when adding new Cluster Mar 24, 2025
@programmiri programmiri force-pushed the GOV-981-update-create-cluster-form branch 2 times, most recently from ebcf2e7 to 7994e2f Compare March 24, 2025 12:16
Signed-off-by: Mirjam Aulbach <mirjam.aulbach@aiven.io>
Signed-off-by: Mirjam Aulbach <mirjam.aulbach@aiven.io>
@programmiri programmiri force-pushed the GOV-981-update-create-cluster-form branch from 43b746a to 0984e22 Compare March 24, 2025 14:48
@programmiri programmiri marked this pull request as ready for review March 24, 2025 14:59
Copy link
Contributor

@aindriu-aiven aindriu-aiven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you

@aindriu-aiven aindriu-aiven merged commit effa415 into main Mar 24, 2025
19 checks passed
@aindriu-aiven aindriu-aiven deleted the GOV-981-update-create-cluster-form branch March 24, 2025 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants