Csrf fix #2858
Open
Csrf fix #2858
+471
−97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Muralidhar Basani <muralidhar.basani@aiven.io>
Signed-off-by: Muralidhar Basani <muralidhar.basani@aiven.io>
Signed-off-by: Mirjam Aulbach <mirjam.aulbach@aiven.io>
programmiri
reviewed
Mar 28, 2025
|
|
||
| const headers = { | ||
| ...options.headers, | ||
| ...(csrfToken ? { "X-CSRF-TOKEN": csrfToken } : {}), |
There was a problem hiding this comment.
As far as I understand it, usually X-XSRF-TOKEN is enough, but it seems BE expects X-XSRF-TOKEN to be sent, too. There may be a legacy/backwards-compatibility config in BE for this. Angular sends both, so I added it to be consistent (and well, because we need to to work :D)
There was a problem hiding this comment.
Good one. I missed to update it back.
Now I updated BE to use only X-XSRF-TOKEN. It works in Angular.
Can you pls try removing it and see if it works in react too ?
There was a problem hiding this comment.
this is my only outstanding question as well aside from that i think it looks good.
Signed-off-by: Muralidhar Basani <muralidhar.basani@aiven.io>
roope-kar
previously approved these changes
Mar 31, 2025
Signed-off-by: Muralidhar Basani <muralidhar.basani@aiven.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked issue
Resolves: #xxxxx
What kind of change does this PR introduce?
What is the current behavior?
Describe the state of the application before this PR. Illustrations appreciated (videos, gifs, screenshots).
What is the new behavior?
Describe the state of the application after this PR. Illustrations appreciated (videos, gifs, screenshots).
Other information
Additional changes, explanations of the approach taken, unresolved issues, necessary follow ups, etc.
Requirements (all must be checked before review)
mainbranch have been pulledpnpm linthas been run successfully