Use --no-sync for pg_receivewal #642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdunklau
force-pushed
the
rdunklau/use_no_sync_option
branch
from
ea32e4e to
cf91435
Compare
rdunklau
changed the title
rdunklau
force-pushed
the
rdunklau/use_no_sync_option
branch
3 times, most recently
from
7eed3d1 to
18287e6
Compare
egor-voynov-aiven
previously requested changes
Mar 28, 2025
rdunklau
dismissed
egor-voynov-aiven’s stale review
It has been discussed during our meeting that the current way is fine.
rdunklau
force-pushed
the
rdunklau/use_no_sync_option
branch
from
18287e6 to
ea32e4e
Compare
Since we are only ever dumping it to a temp directory, use the --no-sync argument.
rdunklau
force-pushed
the
rdunklau/use_no_sync_option
branch
from
ea32e4e to
9541026
Compare
rdunklau
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we are only ever dumping it to a temp directory, use the --no-sync
argument.
About this change - What it does
Resolves: #xxxxx
Why this way