Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENH]: enhance privacy by limiting accuracy of lat and long values #391

Open
NormannK opened this issue Jan 19, 2025 · 3 comments · May be fixed by #400
Open

[ENH]: enhance privacy by limiting accuracy of lat and long values #391

NormannK opened this issue Jan 19, 2025 · 3 comments · May be fixed by #400
Labels
enhancement New feature or request

Comments

@NormannK
Copy link
Collaborator

NormannK commented Jan 19, 2025 •
edited
Loading

Link to discussion and related issues

Any latitude and longitude values managed by the system should be restricted to an accuracy level that prevents exposing the user's precise location when transmitted via an API or included in outputs, such as debug data in a GitHub issue. If these values are stored in a configuration file, the stored data should reflect the same limited accuracy.

Accuracy versus decimal places at the equator

decimal  degrees    distance
places
-------------------------------  
0        1.0        111 km
1        0.1        11.1 km
2        0.01       1.11 km
3        0.001      111 m
4        0.0001     11.1 m
5        0.00001    1.11 m
6        0.000001   0.111 m
7        0.0000001  1.11 cm
8        0.00000001 1.11 mm

I propose a accuracy of 1.11 km so two decimal places.

Proposed implementation


      		
    

      
  





        



            

              
            

        

      


      
    








      

    



      

  
            

    

      
    

    


      

          @NormannK
NormannK




          added
  the 

  enhancement

  New feature or request
 label


      Jan 19, 2025

    

  








      

  
      



  

  @b0661





  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

  
    Collaborator


      

  


  

    

      

      
            b0661
  

      

      

      commented


        Jan 19, 2025


      
    


  





      


        


  
    

      
          
We should delegate private configuration data to a Secrets File such that in normal data only the reference to the Secret Key but Not the value itself is visible. See Home Assistent for an example.

      		
    

  





        


            

            

              
            

        

      


      

            
  

    
  
    
    

  

  



    












      

  
      



  

  @NormannK





  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

  
    Collaborator


      

  Author


  


  

    

  





      


        


  
    

      
          
that's a great way to do it! On the other hand if we don't need the information/accuracy we should not save it in the first place.

What else could we store in the Secret File currently?

      		
    

  





        


            

            

              
            

        

      


      

            
  

    
  
    
    

  

  



    












      

  
      



  

  @b0661





  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

  
    Collaborator


      

  


  

    

      

      
            b0661
  

      

      

      commented


        Jan 20, 2025


      
    


  





      


        


  
    

      
          


that's a great way to do it! On the other hand if we don't need the information/accuracy we should not save it in the first place. What else could we store in the Secret File currently?




Private API-keys.

      		
    

  





        


            

            

              
            

        

      


      

            
  

    
  
    
    

  

  



    












      

  
          

  

    
  


  

      

    @b0661
b0661



    linked a pull request
    
      Jan 21, 2025
    

    that will
    close
    this issue





  


  

      
   Open

  







  













  
  

    

      

  





  




  
  

              

  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment


  



  






  
                  




    

  


      
  

    Assignees
  



        

    No one assigned







      


  


  

    Labels
  



    

      

    enhancement

  New feature or request








      

  

    

        

    Projects
  


        




    None yet




  



      


  

    
  

    Milestone
  


      No milestone





    
      
          


  

    
      

        
    

    Development
  




          
  
Successfully merging a pull request may close this issue.





    


  
          
      Enhance secret configuration

    
      b0661/EOS
    





    
  




      

    

  
      

  

    

      2 participants
    

    

        
          @b0661 
        
          @NormannK