Enhance secret configuration #400
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enhance configuration to support secret configuration values.
Secret configuration values are held in a secrets file.
In the "normal" configuration the secret configuration can be referenced
by the value "!secret <secret_key>".
The secret can only be accessed by config.secret("<key>") which follows
the indirection if there is any, otherwise it returns the current value.
If the secret value is accessed by config.<key> and there is a secret
redirection "!secret <secret_key>" will be returned, thus hiding the secret.
Signed-off-by: Bobby Noelte <[email protected]>
|
We switch to nested config. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhance configuration to support secret configuration values. Secret configuration values are held in a secrets file.
In the "normal" configuration the secret configuration can be referenced by the value "!secret <secret_key>".
The secret can only be accessed by config.secret("<key>") which follows the indirection if there is any, otherwise it returns the current value. If the secret value is accessed by config.<key> and there is a secret redirection then "!secret <secret_key>" will be returned, thus hiding the secret.
Closes #391
Should wait for #389 to cover nested configuration.