-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make EOS packable by Python/PyPI #115
Conversation
Signed-off-by: Bobby Noelte <[email protected]>
We should directly create an issue due to Docker. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please correct the failing checks
Signed-off-by: Bobby Noelte <[email protected]>
Signed-off-by: Bobby Noelte <[email protected]>
Corrected. Sorry did not remember to install pre-commit to my local repo. |
Add packaging information and make it usable by Makefile. Signed-off-by: Bobby Noelte <[email protected]>
Signed-off-by: Bobby Noelte <[email protected]>
Adapted the Dockerfile. This is untested. @dsiebel, @michaelosthege, could you have a look on the Dockerfile. I think it has to be changed anyway as mariadb is now gone. |
I'm interested in using EOS as a library and application to be provided by PyPI
The current directory structure does not support that easily. This pull request changes the directory layouts following best practise suggested in the Python packaging tutorial.
As EOS as a package name is already in use in PyPI the package project name akkudoktor-eos is used. Packages shall not have a dash in Python, therefor the lengthy akkudoktoreos is used.
The pull request moves and adapts source and test files. The directory structure is adapted to:
├── LICENSE
├── pyproject.toml
├── README.md
├── src/
│ └── akkudoktoreos/ ------------------ the library (mostly from current modules directory)
│ ├── init.py
│ ├── class_akku.py
│ └── ....py
│ └── akkudoktoreosserver/ -------- the flask server
│ ├── init.py
│ └── flask_server.py
└── tests/
└── ... as now, besides modules/
The pull request passed the tests and and the flask server also runs.
Docker will not work as the Dockerfile is not adapted.
This pull request closes #114.
Discussed in #106
Originally posted by b0661 October 6, 2024
Cheers
Bobby