Improve EOSdash. #417

b0661 · 2025-01-25T20:31:25Z

Make EOSdash use UI components from MonsterUI to ease further development.

Add a first menu with some dummy pages and the configuration page.
Make the configuration scrollable.
Add markdown component that uses markdown-it-py (same as used by
the myth-parser for documentation generation).
Add bokeh (https://docs.bokeh.org/) component for charts
Added several prediction charts to demo
Add a footer that displays connection status with EOS server
Add logo and favicon

Update EOS server:

Provide health endpoint for alive checking.
Move error message generation to extra module

For feature branch: feature/config-nested. Based on #431 (to be merged first)

b0661 · 2025-01-26T16:26:31Z

Ready for review and merge.

Lasall

I'm very excited to check it out, can you upload footer.py as well?
ModuleNotFoundError: No module named 'akkudoktoreos.server.dash.footer'

src/akkudoktoreos/server/eos.py

src/akkudoktoreos/server/eosdash.py

b0661 · 2025-01-26T17:24:11Z

I'm very excited to check it out, can you upload footer.py as well? ModuleNotFoundError: No module named 'akkudoktoreos.server.dash.footer'

Sorry, test for EOSdash is definitively missing. Module added now.

Lasall · 2025-01-26T17:37:06Z

Looks pretty nice!
The content of the table (at least dark mode) is quite difficult to read.

Also after initial load the footer shows "Footer" for 5sec.

NormannK · 2025-01-26T23:02:13Z

after starting eos on windows accessing http://localhost:8503/ i get the 404.

access to eosdash does work (http://localhost:8504/)

very nice.

Documentation link should open in a new tab.

b0661 · 2025-01-27T07:20:58Z

after starting eos on windows accessing http://localhost:8503/ i get the 404.

Please wait a little bit and refresh. It takes some time for EOSdash to start up. Maybe we have to add a longer timeout here until display of the page.

NormannK · 2025-01-27T07:36:42Z

I did wait several minutes. same result. some kind of console output like Loading .... | ... Loading finished would be great.

NormannK · 2025-01-27T07:39:51Z

I did wait several minutes. same result. some kind of console output like Loading .... | ... Loading finished would be great.

some minutes after that and many refreshes i get:

b0661 · 2025-01-27T13:19:38Z

Looks pretty nice! The content of the table (at least dark mode) is quite difficult to read.

Now used themed content. Should be better readable.

Also after initial load the footer shows "Footer" for 5sec.

Footer needs to wait for alive connection result. Now a loading symbol is displayed for the first 5 seconds.

b0661 · 2025-01-27T13:23:20Z

I did wait several minutes. same result. some kind of console output like Loading .... | ... Loading finished would be great.

some minutes after that and many refreshes i get:

Your EOS server does not supply the openapi.json. Seems to be related to the EOS server. Could you please check.

NormannK · 2025-01-28T15:57:50Z

sorry but it does not start anymore. same 404 on 8503 and http://localhost:8504/ gets a "Internal Server Error" without any further debug information. I did delete all config/cache folders before starting it.

b0661 · 2025-01-28T18:38:16Z

sorry but it does not start anymore. same 404 on 8503 and http://localhost:8504/ gets a "Internal Server Error" without any further debug information. I did delete all config/cache folders before starting it.

Please assure you did install all required packages.

make pip-dev

If it still does not work, please only start eosdash and provide the error output:

.venv/bin/python src/akkudoktoreos/server/eosdash.py --reload True

NormannK · 2025-01-28T19:20:26Z

sorry but it does not start anymore. same 404 on 8503 and http://localhost:8504/ gets a "Internal Server Error" without any further debug information. I did delete all config/cache folders before starting it.

Please assure you did install all required packages.
make pip-dev
If it still does not work, please only start eosdash and provide the error output:
.venv/bin/python src/akkudoktoreos/server/eosdash.py --reload True

https://pastebin.com/s4n3N2B8

b0661 · 2025-01-28T20:24:41Z

sorry but it does not start anymore. same 404 on 8503 and http://localhost:8504/ gets a "Internal Server Error" without any further debug information. I did delete all config/cache folders before starting it.

@NormannK, Please try the new version.

NormannK · 2025-01-28T20:25:35Z

done. http://localhost:8504/ does load again. looks good.
8503 same 404

edit:
in the footer:
HTTPConnectionPool(host='0.0.0.0', port=8503): Max retries exceeded with url: /v1/health (Caused by NewConnectionError('<urllib3.connection.HTTPConnection object at 0x000001CAD82736D0>: Failed to establish a new connection: [WinError 10049] The requested address is not valid in its context'))

b0661 · 2025-01-28T20:39:42Z

done. http://localhost:8504/ does load again. looks good. 8503 same 404

edit: in the footer: HTTPConnectionPool(host='0.0.0.0', port=8503): Max retries exceeded with url: /v1/health (Caused by NewConnectionError('<urllib3.connection.HTTPConnection object at 0x000001CAD82736D0>: Failed to establish a new connection: [WinError 10049] The requested address is not valid in its context'))

Footer is ok. EOS is not running and this is the lengthy error message. Should vanish when you start EOS.

Did you also start EOS?

b0661 · 2025-02-02T21:55:09Z

done. http://localhost:8504/ does load again. looks good. 8503 same 404
edit: in the footer: HTTPConnectionPool(host='0.0.0.0', port=8503): Max retries exceeded with url: /v1/health (Caused by NewConnectionError('<urllib3.connection.HTTPConnection object at 0x000001CAD82736D0>: Failed to establish a new connection: [WinError 10049] The requested address is not valid in its context'))

Footer is ok. EOS is not running and this is the lengthy error message. Should vanish when you start EOS.

Did you also start EOS?

@NormannK, please try the new version. Should now detect if a server is already running. Hopefully this helps.

src/akkudoktoreos/server/eos.py

src/akkudoktoreos/core/cache.py

b0661 · 2025-02-07T19:12:12Z

Updated. Please Test.

E.g. new demo page.

Lasall

Great dashboard changes + cache improvments. Could already drop the demo (force of demo settings) and display the real system, probably have to adjust the test then a little.
I would probably also go as far as separate the backend/frontend more (different repos) as the dependencies and assets start diverging. But that's a different discussion/PR.

Only remark I have: Let's let the user decide about their app startup (systemd, docker-compose, initXYZ, ...) and we can drop a dependency and remove some controlling code. Currently it would block startup if I have the server-file open for some reason (e.g. development).

Lasall · 2025-02-07T23:06:35Z

src/akkudoktoreos/server/eos.py

@@ -171,9 +90,26 @@ def start_eosdash() -> subprocess.Popen:
        access_log = args.access_log
        reload = args.reload

+    # Check if EOSdash process is already running


init system

Lasall · 2025-02-07T23:10:48Z

src/akkudoktoreos/server/eos.py

@@ -912,28 +1028,25 @@ def site_map() -> RedirectResponse:

 # Keep the proxy last to handle all requests that are not taken by the Rest API.

-if config_eos.server.startup_eosdash:


did it break the proxy?

did it break the proxy?

Proxy operation is not related to startup_eosdash. EOSdash may be started by other means.

Lasall · 2025-02-07T23:12:05Z

src/akkudoktoreos/server/eos.py

@@ -1004,6 +1117,21 @@ def run_eos(host: str, port: int, log_level: str, access_log: bool, reload: bool
    # Make hostname Windows friendly
    if host == "0.0.0.0" and os.name == "nt":
        host = "localhost"
+
+    # Check if EOSdash process is already running


init system

Lasall · 2025-02-07T23:13:11Z

src/akkudoktoreos/server/eosdash.py

    """
    # Make hostname Windows friendly
    if host == "0.0.0.0" and os.name == "nt":
        host = "localhost"
+
+    # Check if EOSdash process is already running


init system

b0661 · 2025-02-08T00:23:49Z

Could already drop the demo (force of demo settings) and display the real system, probably have to adjust the test then a little.

Demo is for situations where we do not have a full config or the config is invalid - e.g. first time use. Maybe the Demo button can be made configurable, so a user can just decide it not to be shown.

b0661 · 2025-02-08T00:28:14Z

Currently it would block startup if I have the server-file open for some reason (e.g. development).

EOSdash would not start up if another EOSdash is already running on the same host. This is by intention. Can you explain why this is a problem?

Lasall · 2025-02-08T00:35:19Z

With the current implementation it also does not start up if I access the file in any other way, e.g. vim ...py . Let's keep any advanced startup handling to the OS.

b0661 · 2025-02-08T01:01:44Z

With the current implementation it also does not start up if I access the file in any other way, e.g. vim ...py . Let's keep any advanced startup handling to the OS.

Ok, I see. The criterium for the correct process is to weak.

* Move the caching module to core. Add an in memory cache that for caching function and method results during an energy management run (optimization run). Two decorators are provided for methods and functions. * Improve the file cache store by load and save functions. Make EOS load the cache file store on startup and save it on shutdown. Add a cyclic task that cleans the cache file store from outdated cache files. * Improve startup of EOSdash by EOS Make EOS starting EOSdash adhere to path configuration given in EOS. The whole environment from EOS is now passed to EOSdash. Should also prevent test errors due to unwanted/ wrong config file creation. * Allow to check server process startup by health status Both servers now provide a health endpoint that can be used to detect whether the server is running. This is also used for testing now. * Add administration endpoints to control caching from REST API. * Improve test support (to be able to test caching) - Add system test option to pytest for running tests with "real" resources - Add new test fixture to start server for test class Signed-off-by: Bobby Noelte <[email protected]>

Make EOSdash use UI components from MonsterUI to ease further development. - Add a first menu with some dummy pages and the configuration page. - Make the configuration scrollable. - Add markdown component that uses markdown-it-py (same as used by the myth-parser for documentation generation). - Add bokeh (https://docs.bokeh.org/) component for charts - Added several prediction charts to demo - Add a footer that displays connection status with EOS server - Add logo and favicon Update EOS server: - Move error message generation to extra module Signed-off-by: Bobby Noelte <[email protected]>

b0661 force-pushed the add_eosapp branch 3 times, most recently from e36c529 to cc29506 Compare January 26, 2025 15:12

b0661 requested review from NormannK and Lasall January 26, 2025 16:25

Lasall reviewed Jan 26, 2025

View reviewed changes

src/akkudoktoreos/server/eos.py Outdated Show resolved Hide resolved

src/akkudoktoreos/server/eosdash.py Show resolved Hide resolved

b0661 force-pushed the add_eosapp branch from cc29506 to e12109b Compare January 26, 2025 17:22

b0661 force-pushed the add_eosapp branch from e12109b to ec5a275 Compare January 27, 2025 13:17

b0661 force-pushed the add_eosapp branch 2 times, most recently from fb46c19 to 4ab0561 Compare January 27, 2025 19:47

Lasall approved these changes Jan 27, 2025

View reviewed changes

b0661 force-pushed the add_eosapp branch from 4ab0561 to e8a0f72 Compare January 28, 2025 20:19

b0661 force-pushed the add_eosapp branch 2 times, most recently from 38fee88 to e5ab66d Compare February 2, 2025 21:42

NormannK reviewed Feb 4, 2025

View reviewed changes

src/akkudoktoreos/server/eos.py Outdated Show resolved Hide resolved

NormannK reviewed Feb 4, 2025

View reviewed changes

src/akkudoktoreos/core/cache.py Outdated Show resolved Hide resolved

b0661 force-pushed the add_eosapp branch 2 times, most recently from 64c7fa2 to 1c29f85 Compare February 7, 2025 19:04

Lasall reviewed Feb 7, 2025

View reviewed changes

b0661 force-pushed the add_eosapp branch 2 times, most recently from dd36445 to 4c54550 Compare February 8, 2025 00:13

b0661 force-pushed the add_eosapp branch from 4c54550 to 6e0514d Compare February 8, 2025 00:39

b0661 force-pushed the add_eosapp branch from 6e0514d to d4f247c Compare February 8, 2025 01:18

b0661 added 2 commits February 8, 2025 03:09

b0661 force-pushed the add_eosapp branch from d4f247c to 25e0132 Compare February 8, 2025 02:13

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Improve EOSdash. #417

Improve EOSdash. #417

b0661 commented Jan 25, 2025 •

edited

Loading

b0661 commented Jan 26, 2025 •

edited

Loading

Lasall left a comment

b0661 commented Jan 26, 2025 •

edited

Loading

Lasall commented Jan 26, 2025

NormannK commented Jan 26, 2025 •

edited

Loading

b0661 commented Jan 27, 2025

NormannK commented Jan 27, 2025

NormannK commented Jan 27, 2025

b0661 commented Jan 27, 2025

b0661 commented Jan 27, 2025

NormannK commented Jan 28, 2025

b0661 commented Jan 28, 2025 •

edited

Loading

NormannK commented Jan 28, 2025

b0661 commented Jan 28, 2025

NormannK commented Jan 28, 2025 •

edited

Loading

b0661 commented Jan 28, 2025 •

edited

Loading

b0661 commented Feb 2, 2025

b0661 commented Feb 7, 2025

Lasall left a comment

Lasall Feb 7, 2025

Lasall Feb 7, 2025

b0661 Feb 8, 2025

Lasall Feb 7, 2025

Lasall Feb 7, 2025

b0661 commented Feb 8, 2025

b0661 commented Feb 8, 2025

Lasall commented Feb 8, 2025

b0661 commented Feb 8, 2025

		@@ -912,28 +1028,25 @@ def site_map() -> RedirectResponse:

		# Keep the proxy last to handle all requests that are not taken by the Rest API.

		if config_eos.server.startup_eosdash:

Improve EOSdash. #417

Are you sure you want to change the base?

Improve EOSdash. #417

Conversation

b0661 commented Jan 25, 2025 • edited Loading

b0661 commented Jan 26, 2025 • edited Loading

Lasall left a comment

Choose a reason for hiding this comment

b0661 commented Jan 26, 2025 • edited Loading

Lasall commented Jan 26, 2025

NormannK commented Jan 26, 2025 • edited Loading

b0661 commented Jan 27, 2025

NormannK commented Jan 27, 2025

NormannK commented Jan 27, 2025

b0661 commented Jan 27, 2025

b0661 commented Jan 27, 2025

NormannK commented Jan 28, 2025

b0661 commented Jan 28, 2025 • edited Loading

NormannK commented Jan 28, 2025

b0661 commented Jan 28, 2025

NormannK commented Jan 28, 2025 • edited Loading

b0661 commented Jan 28, 2025 • edited Loading

b0661 commented Feb 2, 2025

b0661 commented Feb 7, 2025

Lasall left a comment

Choose a reason for hiding this comment

Lasall Feb 7, 2025

Choose a reason for hiding this comment

Lasall Feb 7, 2025

Choose a reason for hiding this comment

b0661 Feb 8, 2025

Choose a reason for hiding this comment

Lasall Feb 7, 2025

Choose a reason for hiding this comment

Lasall Feb 7, 2025

Choose a reason for hiding this comment

b0661 commented Feb 8, 2025

b0661 commented Feb 8, 2025

Lasall commented Feb 8, 2025

b0661 commented Feb 8, 2025

b0661 commented Jan 25, 2025 •

edited

Loading

b0661 commented Jan 26, 2025 •

edited

Loading

b0661 commented Jan 26, 2025 •

edited

Loading

NormannK commented Jan 26, 2025 •

edited

Loading

b0661 commented Jan 28, 2025 •

edited

Loading

NormannK commented Jan 28, 2025 •

edited

Loading

b0661 commented Jan 28, 2025 •

edited

Loading