Config: Don't fail on config error, fix Windows config dir #426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Lasall
commented
Jan 26, 2025
Lasall
commented
- Support setting logger level (env) before config load.
* Support setting logger level (env) before config load.
|
still crashes if env/dotenv has an error (but maybe an improvement) |
|
how am i supposed to test this? |
|
The Windows user location should now be ...Appdata\akkudoktor\net.akkud... (no longer double net..). Also if your config is invalid, eos should start with default config and show error log. And also if your config is invalid the env variable EOS_LOGGING__LEVEL=DEBUG should still set the app logging level. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.