Windows: Fix EOSdash startup Closes #436 #447 #450
Merged
+26
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lasall
force-pushed
the
dl_dev-windows2
branch
from
0d3a6e2 to
1e34968
Compare
|
Edit: Reverted back so Windows ist 127.0.0.1 and all others are 0.0.0.0. |
Lasall
force-pushed
the
dl_dev-windows2
branch
3 times, most recently
from
50bba27 to
a35366f
Compare
NormannK
approved these changes
Feb 9, 2025
There was a problem hiding this comment.
a hint in the readme to find the docs under http://127.0.0.1:8503/docs would be great. feature branch has that so main might not need it until then.
…#447 * On Windows use 127.0.0.1 as default config host (model defaults) and addionally redirect 0.0.0.0 to localhost on Windows (because default config file still has 0.0.0.0). Use 0.0.0.0 as default otherwise (e.g. Linux/Docker) to allow EOS being accessible on local network (not just same host). Note: Docs generation on Windows is incompatible with the Github pipeline tests. Address this in the nested-config feature branch. * Update install/startup instructions as package installation is required atm and Docker on Windows has to be accessed at localhost or 127.0.0.1 even though the server log says 0.0.0.0 (which is required to be available outside the container). * Fix EOSdash startup with read_only: true (support session key via EOS_SERVER__EOSDASH_SESSKEY variable). Backport of feature branch. * Remove root_path, causing Windows to fail load swagger UI (/docs).
Lasall
force-pushed
the
dl_dev-windows2
branch
from
a35366f to
5b178ae
Compare
|
Updated the README |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addionally redirect 0.0.0.0 to localhost on Windows (because default
config file still has 0.0.0.0).
Use 0.0.0.0 as default otherwise (e.g. Linux/Docker) to allow EOS
being accessible on local network (not just same host).
Note: Docs generation on Windows is incompatible with the Github
pipeline tests. Address this in the nested-config feature branch.
required atm and Docker on Windows has to be accessed at localhost or
127.0.0.1 even though the server log says 0.0.0.0 (which is required
to be available outside the container).
EOS_SERVER__EOSDASH_SESSKEY variable). Backport of feature branch.