Implement scrolling on the background of the waybar #3401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A cleaner way to do this would most likely be to split the code for scroll direction out into the util namespace. |
|
Rebased to make this easier to merge. |
Alexays
force-pushed
the
master
branch
2 times, most recently
from
d623a89
to
a4d31ab
Compare
This experience made me hate GTK 3.0. There's some duplicate code as a result of this too, for checking scroll direction. Smooth scrolling is not handled at all for the bar itself. Signed-off-by: John M. Harris Jr. <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch allows user events for scrolling on the waybar itself, when the mouse is not over a module.
This experience made me hate GTK 3.0. There's some duplicate code as a result of this too, for checking scroll direction. Smooth scrolling is not handled at all for the bar itself.
This could potentially be done in a better way with the C API.