Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed a typo in power_menu.xml and reformat example #3723

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

sergeyklay
Copy link

@sergeyklay sergeyklay commented Oct 29, 2024

Unified shutdown and reboot commands to use the modern systemd approach, replacing legacy SysVinit-style commands. This aligns the entire menu with the standard for contemporary distributions, enhancing consistency.

Formatted indentation in power_menu.xml for readability, converting mixed spaces and tabs to 2-space indentation for better display on small screens.

Fixed a typo in power_menu.xml by correcting id="hibernat" to id="hibernate".

Unified `shutdown` and `reboot` commands to use the modern systemd
approach, replacing legacy SysVinit-style commands. This aligns the
entire menu with the standard for contemporary distributions,
enhancing consistency.

Formatted indentation in `power_menu.xml` for readability, converting
mixed spaces and tabs to 2-space indentation for better display on
small screens.

Fixed a typo in `power_menu.xml` by correcting `id="hibernat"` to
`id="hibernate"`.
@LukashonakV
Copy link
Contributor

Not sure systemctl is a standard. It depends on login manager in chain with init manager. For example for non systemd init system like elogind - standard command starts with loginctl. See elogind
This is exact my case

@sergeyklay
Copy link
Author

sergeyklay commented Oct 30, 2024

Not sure systemctl is a standard. It depends on login manager in chain with init manager. For example for non systemd init system like elogind - standard command starts with loginctl. See elogind This is exact my case

I’m not here to argue about the spread or popularity of systemd. At the very least, I believe those users who manage their systems without systemd can do more than just copy-paste code from a guide — they can adapt it. Either way, my task was to unify the guide. As I mentioned above the goal is to enhancing consistency — half of the examples used systemd, while the other half were in a SysVinit style.

@LukashonakV
Copy link
Contributor

Not sure systemctl is a standard. It depends on login manager in chain with init manager. For example for non systemd init system like elogind - standard command starts with loginctl. See elogind This is exact my case

I’m not here to argue about the spread or popularity of systemd. At the very least, I believe those users who manage their systems without systemd can do more than just copy-paste code from a guide — they can adapt it. Either way, my task was to unify the guide. As I mentioned above the goal is to enhancing consistency — half of the examples used systemd, while the other half were in a SysVinit style.

Doesn't existing solution work in systemd? At least out of the box is working well in elogind.
If it does work well out of the box, both init systems, then such change won't impact systemd users, but will bring one more action to the rest users they should do before module usage. Am I wrong?

@sergeyklay
Copy link
Author

If it does work well out of the box, both init systems, then such change won't impact systemd users, but will bring one more action to the rest users they should do before module usage. Am I wrong?

Alright, that sounds reasonable. Your arguments convinced me - I reverted those changes.

@sergeyklay sergeyklay changed the title Standardize shutdown and reboot commands in power_menu.xml Fixed a typo in power_menu.xml and reformat example Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants