Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OPSEXP-3165: fix disabling audit storage #1312

Open
wants to merge 4 commits into
base: release/v8.6
Choose a base branch
from
Open

OPSEXP-3165: fix disabling audit storage #1312

wants to merge 4 commits into from
+43 −33

Conversation

alxgomz
Copy link
Contributor

@alxgomz alxgomz commented Mar 10, 2025

@alxgomz alxgomz requested a review from pmacius March 10, 2025 22:54
pmacius
pmacius previously approved these changes Mar 11, 2025
View reviewed changes
Copy link
Contributor

@pmacius pmacius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unit tests are passing locally.
Disabling audit related components no longer tries to create env vars in configmap

@pmacius pmacius requested a review from gionn March 11, 2025 10:21
@alxgomz alxgomz force-pushed the OPSEXP-3165 branch 2 times, most recently from fcbc6e2 to 2cacc9f Compare March 11, 2025 12:05
gionn
gionn requested changes Mar 11, 2025
View reviewed changes
Copy link
Member

@gionn gionn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

always merge first to master, then backport to release branch, otherwise we end up not knowing what is on release branch and what is on master

@alxgomz
Copy link
Contributor Author

alxgomz commented Mar 11, 2025

PR for master: #1315

@alxgomz alxgomz requested a review from gionn March 11, 2025 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmacius pmacius pmacius approved these changes

@gionn gionn Awaiting requested review from gionn

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alxgomz @gionn @pmacius