Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add exaspim qc example #1294

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from
Open

Conversation

saskiad
Copy link
Collaborator

@saskiad saskiad commented Mar 3, 2025

closes #1293

@saskiad saskiad requested a review from dbirman March 3, 2025 02:12
@saskiad
Copy link
Collaborator Author

saskiad commented Mar 3, 2025

This is making an example of a QC annotation for the exaspim neuron reconstructions. I'm happy to see if there are better ways to do this (ala curation) but trying to squeeze the info that that team is looking to track into the system.

Copy link
Member

@dbirman dbirman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah everything here looks good as far as code -- but I agree with the sentiment that this isn't quite what we want to use QC for and we need another kind of structure for these kinds of annotations. I think this Curation object idea is the solution. Something to discuss more soon since we might want to squeeze it into 2.0.

I also I don't know why but one of the other examples files (that you didn't touch here) is out of date and causing the tests to fail. I pushed an update for it to the PR.

Edit: for some reason the tests are still failing... not sure what's going on because they work on my local machine.

@saskiad
Copy link
Collaborator Author

saskiad commented Mar 3, 2025

yeah, I'm confused by the tests failing because I had everything synced to be up to date ... but I'll need to look at them again and figure out what's going on.
I'm meeting with the exaspim morphology folks tomorrow, so I'll show them this and see if they have other needs for their curation. Do you want to join?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create an example QC/Curation for exaspim reconstruction
2 participants