BREAKING CHANGE: InjectionDynamics #1296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…imeconcentration-with-injectiondynamics-2
…imeconcentration-with-injectiondynamics-2
…imeconcentration-with-injectiondynamics-2
saskiad
reviewed
Mar 5, 2025
saskiad
reviewed
Mar 5, 2025
| injection_eye: Side = Field(..., title="Injection eye") | ||
|
|
||
|
|
||
| class IntraperitonealInjection(Injection): | ||
| """Description of an intraperitoneal injection procedure""" | ||
|
|
||
| time: Optional[AwareDatetimeWithDefault] = Field(default=None, title="Injection time") |
There was a problem hiding this comment.
don't remove the time here - it's not a duration field, it's the time when the injection is done. This is for the NBA project where they do timed injections prior to blood collection.
saskiad
reviewed
Mar 5, 2025
saskiad
reviewed
Mar 5, 2025
saskiad
reviewed
Mar 5, 2025
| injection_duration: Optional[Decimal] = Field(default=None, title="Injection duration") | ||
| injection_duration_unit: Optional[TimeUnit] = Field(default=None, title="Injection duration unit") | ||
| dynamics: List[InjectionDynamics] = Field( | ||
| ..., title="Injection dynamics", description="List of injection events, pattern should match the profile" |
There was a problem hiding this comment.
maybe indicate one per injection depth or location?
…imeconcentration-with-injectiondynamics-2
…imeconcentration-with-injectiondynamics-2
saskiad
approved these changes
Mar 7, 2025
dbirman
deleted the
1235-20-injections-replace-volumetimeconcentration-with-injectiondynamics-2
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new concept to the
Injectionclass.InjectionDynamicswrap thevolume,rate, anddurationtogether into a single class that is shared across all injections. The dynamics comes in because the fieldInjection.dynamicsaccepts aList[InjectionDynamics], allowing people to describe in as much detail as they want the pattern of an injection -- if it's important. All existing injections can probably be ported simply as bolus injections.In addition I added a concept
InjectionProfilewhich provides an english-language description of the type of injection. I gave it three options bolus/continuous/pulsed for different types of injection I've seen. There are probably more. A validator prevents users from putting multiple injection events in while describing it as a bolus injection.I also fixed several tests that turned out to not be working at all.