Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1262 make tarsvirusidentifiersplasmid tars alias a list #1301

Merged
merged 3 commits into from
Mar 5, 2025
Merged

1262 make tarsvirusidentifiersplasmid tars alias a list #1301

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a27496e
refactor: List[str] instead of str for plasmid_tars_alias
dbirman Mar 5, 2025
93a9601
chore: add an actual list example
dbirman Mar 5, 2025
3b9bc9b
fix: missed one
dbirman Mar 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion examples/procedures.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@
name="AAV2-Flex-ChrimsonR",
tars_identifiers=TarsVirusIdentifiers(
virus_tars_id="AiV222",
plasmid_tars_alias="AiP222",
plasmid_tars_alias=["AiP222"],
prep_lot_number="VT222",
),
titer=2300000000,
Expand Down
4 changes: 2 additions & 2 deletions src/aind_data_schema/core/procedures.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -378,9 +378,9 @@ class TarsVirusIdentifiers(DataModel):
"""TARS data for a viral prep"""

virus_tars_id: Optional[str] = Field(default=None, title="Virus ID, usually begins 'AiV'")
plasmid_tars_alias: Optional[str] = Field(
plasmid_tars_alias: Optional[List[str]] = Field(
default=None,
title="Plasmid alias",
title="List of plasmid aliases",
description="Alias used to reference the plasmid, usually begins 'AiP'",
)
prep_lot_number: str = Field(..., title="Preparation lot number")
Expand Down
6 changes: 3 additions & 3 deletions tests/test_procedures.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,7 @@ def test_injection_material_check(self):
name="AAV2-Flex-ChrimsonR",
tars_identifiers=TarsVirusIdentifiers(
virus_tars_id="AiV222",
plasmid_tars_alias="AiP222",
plasmid_tars_alias=["AiP222"],
prep_lot_number="VT222",
),
titer=2300000000,
Expand Down Expand Up @@ -191,7 +191,7 @@ def test_injection_material_check(self):
name="AAV2-Flex-ChrimsonR",
tars_identifiers=TarsVirusIdentifiers(
virus_tars_id="AiV222",
plasmid_tars_alias="AiP222",
plasmid_tars_alias=["AiP222"],
prep_lot_number="VT222",
),
titer=2300000000,
Expand Down Expand Up @@ -337,7 +337,7 @@ def test_coordinate_volume_validator(self):
name="AAV2-Flex-ChrimsonR",
tars_identifiers=TarsVirusIdentifiers(
virus_tars_id="AiV222",
plasmid_tars_alias="AiP222",
plasmid_tars_alias=["AiP222", "AiP223"],
prep_lot_number="VT222",
),
titer=2300000000,
Expand Down