feat: added ophys_procedure py and json #700
Conversation
'latest changes of main applied'
|
This looks good to me - @saskiad ? |
|
Oh wait no I'm not done yet this is still just a draft! I need to get info from Kenta or Bryan about how to fill in the procedure for the ophys stuff. Right now the ophys_procedure.py is just a copy of procedure.py for reference. |
Ah okay, sorry I jumped the gun :) |
|
Used past procedure json from Bryan and added immunology data |
|
I believe I correctly changed some of the wonky things to make more sense. The only thing I'm not sure on is how to correctly format the rrid field of antibody class |
|
@saskiad Is this any better or still not exactly how to use Registry.RRID? I ran into requirement issues with rrid=PIDName(registry = Registry.RRID, registry_identifier= "ab13970") |
see comments in thread above this. (Also as a note, I get so many github notifications in my inbox that I rarely see real ones, so maybe ping me on teams if there is something you need me to look at) |
examples/ophys_procedures.json
Outdated
| "addgene_id": { | ||
| "name": "62723-AAV5", | ||
| "abbreviation": null, | ||
| "registry": null, |
There was a problem hiding this comment.
the registry needs to be Addgene
| material_type="Virus", | ||
| name="AAV2/1-Syn-Flex-ChrimsonR-tdT", | ||
| addgene_id=PIDName( | ||
| name="62723-AAV5", |
There was a problem hiding this comment.
this is missing a Registry - needs to be Addgene
There was a problem hiding this comment.
ah, it's the same thing - but this is the place to fix it
closes #660