Fix running the evaluator from the CLI #308
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems the idea here was to populate an
answersmap with satisfiable solutions, then pass that map to theevaluatormethod. However, theanswersmap is never added to, so the check before calling the evaluator always fails.This PR changes things around a bit so that we just pass the latest solution in to
evaluatordirectly, which makes the evaluator run successfully. Not sure whether this matches with @pkriens' intention (probably not) but it worked for me, so I figured I'd put up a PR in case it's useful.Fixes #307.